Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement joinVariantAnnotations with region join #1259

Closed
heuermh opened this issue Nov 10, 2016 · 2 comments
Closed

Implement joinVariantAnnotations with region join #1259

heuermh opened this issue Nov 10, 2016 · 2 comments
Milestone
0.21.0

Comments

@heuermh
Copy link
Member

heuermh commented Nov 10, 2016

VariantContextRDD.joinVariantAnnotations should be implemented using a region join instead of a Spark core leftOuterJoin.

See comment https://github.com/bigdatagenomics/adam/pull/1250/files#r87030913
@heuermh heuermh mentioned this issue Nov 10, 2016
Closed
@heuermh
Copy link
Member Author

heuermh commented Dec 29, 2016

Note #1288 removes the join between Variant and VariantAnnotation altogether.

@heuermh heuermh modified the milestone: 0.21.0 Jan 4, 2017
@heuermh
Copy link
Member Author

heuermh commented Jan 5, 2017

WontFix due to #1288

@heuermh heuermh closed this as completed Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

No branches or pull requests
1 participant
@heuermh