Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenomicRDD.toXxx method names should be consistent #1699

Closed
heuermh opened this issue Aug 29, 2017 · 1 comment
Closed

GenomicRDD.toXxx method names should be consistent #1699

heuermh opened this issue Aug 29, 2017 · 1 comment
Milestone
0.23.0

Comments

@heuermh
Copy link
Member

heuermh commented Aug 29, 2017

The predefined transmute methods GenomicRDD.toXxx are not named consistently

AlignmentRecordRDD.toCoverage(): CoverageRDD
AlignmentRecordRDD.toFragments(): FragmentRDD
CoverageRDD.toFeatureRDD(): FeatureRDD
FeatureRDD.toCoverage(): CoverageRDD
FragmentRDD.toReads(): AlignmentRecordRDD
GenotypeRDD.toVariantContextRDD(): VariantContextRDD
VariantContextRDD.toGenotypeRDD(): GenotypeRDD
VariantContextRDD.toVariantRDD(): VariantRDD
VariantRDD.toVariantContextRDD(): VariantContextRDD

I propose

AlignmentRecordRDD.toCoverage(): CoverageRDD
AlignmentRecordRDD.toFragments(): FragmentRDD
CoverageRDD.toFeatures(): FeatureRDD
FeatureRDD.toCoverage(): CoverageRDD
FragmentRDD.toReads(): AlignmentRecordRDD
GenotypeRDD.toVariantContexts(): VariantContextRDD
VariantContextRDD.toGenotypes(): GenotypeRDD
VariantContextRDD.toVariants(): VariantRDD
VariantRDD.toVariantContexts(): VariantContextRDD
@fnothaft
Copy link
Member

+1

@heuermh heuermh mentioned this issue Aug 29, 2017
Merged
@heuermh heuermh modified the milestone: 0.23.0 Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

No branches or pull requests
2 participants
@heuermh @fnothaft