Log with parameterized messages consistently for performance

[heuermh]

Per https://www.slf4j.org/faq.html#logging_performance, logging with parameterized messages

log.info("message {} {}", one, two)

is preferable to alternatives found in our code base

log.info("message s% %s".format(one, two))

if (log.isInfoEnabled()) {
  log.info("message s% %s".format(one, two))
}

logInfo("message s% %s".format(one, two)")

See also mention in comment #1684 (comment)

[fnothaft]

+1; also, perhaps everywhere that we've got a log.info(String) call, we can switch to logInfo?

[heuermh]

+1; also, perhaps everywhere that we've got a log.info(String) call, we can switch to logInfo?

Yep, that is what I was thinking.

[fnothaft]

Sounds good!

[heuermh]

Turns out the parameterized message methods in slf4j aren't so convenient to use from scala

[ERROR] adam/adam-core/src/main/scala/org/bdgenomics/adam/rdd/read/realignment/RealignIndels.scala:470:
error: ambiguous reference to overloaded definition,
[WARNING] both method warn in trait Logger of type (x$1: String, x$2: Any, x$3: Any)Unit
[WARNING] and  method warn in trait Logger of type (x$1: String, x$2: <repeated...>[Object])Unit
[INFO] match argument types (String,Option[(Int, org.bdgenomics.adam.rdd.read.realignment.IndelRealignmentTarget)],Throwable)
[WARNING]           log.warn("Realigning target {} failed with {}.", target, t)
[INFO]               ^

I think the best way forward is to commit to logInfo style and then refactor bdg-utils Logging to match and use slf4j parameterized message methods under the hood.

[heuermh]

Note http://software.clapper.org/grizzled-slf4j/ might be of use.