Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add barcodes field to ReadGroup #182

Closed
heuermh opened this issue Aug 10, 2019 · 3 comments
Closed

Add barcodes field to ReadGroup #182

heuermh opened this issue Aug 10, 2019 · 3 comments
Milestone
0.14.0

Comments

@heuermh
Copy link
Member

heuermh commented Aug 10, 2019

No description provided.

@heuermh
Copy link
Member Author

heuermh commented Aug 10, 2019

See htsjdk commit samtools/htsjdk@5ef9223#diff-26954dc980a2aa8e7caddc4d900f478a

@heuermh heuermh added this to the 0.14.0 milestone Aug 10, 2019
@heuermh heuermh changed the title Add barcode field to ReadGroup Add barcodes field to ReadGroup Sep 4, 2019
@heuermh heuermh mentioned this issue Sep 4, 2019
Closed
@heuermh
Copy link
Member Author

heuermh commented Sep 5, 2019

I'm thinking of closing this as WontFix. We already support the BC tag via attributes, and I find the implementation in htsjdk hacky at best (what about the other barcode tags? what about the barcode sequence quality tags?).

SAM spec

1.3 Barcodes

DNA barcodes can be used to identify the provenance of the underlying reads.
There are currently three varieties of barcodes that may co-exist: Sample Barcode,
Cell Barcode, and Unique Molecular Identifier (UMI).

@heuermh
Copy link
Member Author

heuermh commented Sep 11, 2019

Closing as WontFix

@heuermh heuermh closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

[FORMATS-182] Add barcodes field to ReadGroup heuermh/bdg-formats
1 participant
@heuermh