Implement per-instance error handling #27
Conversation
…r into component classes.
| @@ -2,6 +2,6 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
| if (UNIX) | |||
| add_definitions("-fPIC") | |||
| endif() | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra") | |||
There was a problem hiding this comment.
c++11 flag was causing gcc / ubuntu-latest to not compile c++17
src/btwxt.cpp
Outdated
| RegularGridInterpolator::RegularGridInterpolator(GriddedData &grid_data_in) | ||
| : grid_data(grid_data_in), grid_point(grid_data) {} | ||
| RegularGridInterpolator::RegularGridInterpolator(const std::vector<std::vector<double>> &grid) | ||
| : grid_data(grid), grid_point(grid_data) {} |
There was a problem hiding this comment.
GriddedData and GridPoint classes are now relegated to be convenience objects only, and wholly compose RGI. 1. This makes the RGI interface much more similar to scipy.RegularGridInterpolator, and 2. Only one class, RGI, is exposed outside the library.
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 86.09% 87.13% +1.04%
==========================================
Files 7 6 -1
Lines 453 474 +21
==========================================
+ Hits 390 413 +23
+ Misses 63 61 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fix Issue #12 .
Adjust function return values and signatures as required to implement a class-level callback. If none is provided, fall back to global (namespace-level) callback.
Implement module-internal exceptions for fatal errors; do not allow exceptions to propagate out of btwxt.