Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactoring (breaking changes!) #30

Merged
merged 86 commits into from
Jun 12, 2023
Merged

Major refactoring (breaking changes!) #30

merged 86 commits into from
Jun 12, 2023

Conversation

nealkruis
Copy link
Member

Major re-write focusing on code organization and naming conventions.

@tanaya-mankad
Introduce exceptions internal to module(s).
c024f14
@tanaya-mankad
Rewrite error and message handling for GridAxis.
d2ead71
@tanaya-mankad
Fix tests.
b35833b
@tanaya-mankad
Disable fast fail on CI.
b77c721
@tanaya-mankad
Add functional header.
75e0dff
@tanaya-mankad
Update gh actions checkout.
b7567b6
@tanaya-mankad
Try CI with Ubuntu 20.
b17812f
@tanaya-mankad
Try CI with Ubuntu 22.
206e3e4
@tanaya-mankad
Try CI with only working OS values.
8b2b8ba
@tanaya-mankad
Start moving toward saner cmake defaults.
1580727
@tanaya-mankad
Update CI matrix.
53e58b3
@tanaya-mankad
Apply clang-format file.
0d095ef
@tanaya-mankad
Revert return values to simple ones.
d23cf39
@tanaya-mankad
Remove default constructors and adjust tests. Pass callback by pointe…
c9963ed 
…r into component classes.
@tanaya-mankad
Remove vestigial error strings returned by funcs.
182dcf6
@tanaya-mankad
Pass ptr to const function.
16e2c35
@tanaya-mankad
Improve const-correctness; remove redundancy in tests.
6d46ec3
@tanaya-mankad
Disambiguate constructors.
89b4f05
@tanaya-mankad
Construct test_gridded_data directly.
a6d346b
@tanaya-mankad
Put back default constructors; alternative is exactly the same thing.
1691b7f
@tanaya-mankad
Variable cleanup.
5ff6281
@tanaya-mankad
Remove global callback entirely.
21cc1e6
@tanaya-mankad
Separate setting the callback and the context.
788bb26
@tanaya-mankad
Pass string_view by value.
f59fc90
@tanaya-mankad
Merge crom unnecessary branch.
d16a384
@tanaya-mankad
Integrate Courierr logging.
3d290aa
@tanaya-mankad
Make Courierr dependency non-optional; fix constructors and tests acc…
651bb75 
…ordingly.
@tanaya-mankad
Update Courierr.
70cad02
@tanaya-mankad
Add getter for Courierr instance.
fbfa886
@tanaya-mankad
Allow GridAxis to contain a different logger than owning RGI.
42857cb
@nealkruis nealkruis self-assigned this Mar 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #30 (eaeab04) into main (7fe17b5) will decrease coverage by 0.13%.
The diff coverage is 85.96%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   86.09%   85.96%   -0.13%     
==========================================
  Files           7        6       -1     
  Lines         453      520      +67     
==========================================
+ Hits          390      447      +57     
- Misses         63       73      +10
Flag Coverage Δ
integration 85.96% <85.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/btwxt/grid-axis.h 0.00% <0.00%> (ø)
include/btwxt/grid-point-data.h 0.00% <0.00%> (ø)
include/btwxt/logging.h 0.00% <0.00%> (ø)
src/regular-grid-interpolator-implementation.h 13.79% <13.79%> (ø)
src/grid-axis.cpp 85.33% <85.33%> (ø)
src/regular-grid-interpolator.cpp 92.67% <92.67%> (ø)

nealkruis and others added 22 commits March 29, 2023 16:28
@nealkruis
Rename 'Private' to 'Implementation'.
472f5a5
@nealkruis
Clean up test headers.
92a29c3
@nealkruis
Clean up naming consistency.
c49956a
@nealkruis
Clean up index naming.
162bfe9
@nealkruis
Make all implementation members private.
8716f6c
@nealkruis
Rename implementation header file.
284f408
@nealkruis
Rename implementation member variable.
a332bc7
@nealkruis
Add interface target for public headers.
bc68d20
@nealkruis
Increase test coverage. Additional cleanup.
202a68b
@nealkruis
Change logger class name.
c399fa0
@nealkruis
Logging context clean up.
b544430
@tanaya-mankad
Add missing namespace designator.
404a2d4
@tanaya-mankad
Add functions as needed by EnergyPlus integration.
92ee603
@nealkruis
Fix normalization at target after adding a new grid point data set wi…
26eae06 
…th the same target.
@tanaya-mankad
Move all construction definitions into implementation for use with fo…
7e27729 
…rward-declaration.
@tanaya-mankad
Merge branch 'separate-public-header' of https://github.com/bigladder…
fd21da4 
…/btwxt into separate-public-header
@tanaya-mankad
Remove default constructors.
657b3f9
@tanaya-mankad
Revert to including default constructors.
a4e3f98
@tanaya-mankad
Try include guards instead of pragma.
f97745a
@tanaya-mankad
Try include guards to prevent multiple submodules redefining classes.
99e3e8a
@tanaya-mankad
Try include guards to prevent multiple submodules redefining classes.
992f431
@tanaya-mankad
Remove commented line.
eaeab04
@nealkruis nealkruis merged commit 6be280b into main Jun 12, 2023
@nealkruis nealkruis deleted the separate-public-header branch September 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanaya-mankad tanaya-mankad Awaiting requested review from tanaya-mankad

Assignees

@nealkruis nealkruis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nealkruis @codecov-commenter @tanaya-mankad