-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add return types for normalization factor. #9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 84.41% 85.68% +1.27%
==========================================
Files 8 8
Lines 417 419 +2
==========================================
+ Hits 352 359 +7
+ Misses 65 60 -5
Continue to review full report at Codecov.
|
@ajscimone Let's add a couple of unit tests in this repo to ensure we're getting the right output back. You can more-or-less use the same cases we used for EnergyPlus. |
@nealkruis unit tests should now be added for scalar return functionality for both btwxt itself and GridPoints. There are two unit tests apiece, adding four total to the library. I have created a new test fixture named "TwoDSimpleNormalizationFixture" which is a 2D fixture which has very simple data corresponding to a |
… redundant gridpoint tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to go through the math manually, but as Neal's done it, I'll click approve.
…ons and generate regular grid interpolator data using a function instead of hard coding values via a lookup table.
No description provided.