Skip to content

Commit

Permalink
fix filter actionDag has useless column
Browse files Browse the repository at this point in the history
  • Loading branch information
liuneng1994 committed Apr 12, 2022
1 parent 401d6ec commit 502c26c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion utils/local-engine/Parser/SerializedPlanParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ DB::QueryPlanPtr local_engine::SerializedPlanParser::parseOp(const substrait::Re
DB::QueryPlanPtr query_plan = parseOp(filter.input());
std::string filter_name;
auto actions_dag = parseFunction(query_plan->getCurrentDataStream(), filter.condition(), filter_name, nullptr, true);
// actions_dag->removeUnusedActions(query_plan->getCurrentDataStream().header.getNames());
auto filter_step = std::make_unique<DB::FilterStep>(query_plan->getCurrentDataStream(), actions_dag, filter_name, true);
query_plan->addStep(std::move(filter_step));
return query_plan;
Expand Down Expand Up @@ -434,7 +435,7 @@ DB::ActionsDAGPtr local_engine::SerializedPlanParser::parseFunction(
if (arg.has_scalar_function())
{
std::string arg_name;
parseFunction(input, arg, arg_name, actions_dag, true);
parseFunction(input, arg, arg_name, actions_dag, false);
args.emplace_back(&actions_dag->getNodes().back());
}
else
Expand Down

0 comments on commit 502c26c

Please sign in to comment.