Merged
Conversation
- Add config_cmd.py with full implementation of config management - Support dot notation for nested keys (e.g., browsers.chrome) - Validate configuration after changes - Create backup and restore on edit failures - Add comprehensive test suite (22 tests) - Wire up all config subcommands in CLI with proper error handling - Update CLI tests to reflect actual implementation Tests: All 362 tests passing (unit/integration/e2e) Coverage: 81% total, config_cmd.py at 81% covered
- Add doctor.py with comprehensive system checks: * Python version (>= 3.10 required) * Browser availability (chrome, chromium, firefox, edge) * XDG utilities (xdg-mime, update-desktop-database) * Directory write permissions * Desktop environment detection * Config file validity * Registry file validity * Optional dependencies (Playwright) - Wire up doctor command in CLI with colorized output - Add comprehensive test suite (16 tests) - Display summary with pass/fail/warning counts Tests: All 378 tests passing (unit/integration/e2e) Coverage: doctor.py fully covered
- Add completion command with instructions for bash, zsh, and fish - Leverage Click's built-in shell_complete functionality - Provide clear installation instructions for each shell - Add tests for completion command (3 tests) Usage: pwa-forge completion --shell bash pwa-forge completion --shell zsh pwa-forge completion --shell fish Tests: All 381 tests passing (unit/integration/e2e)
- Mark Phase 7 as completed in checklist - Update implementation status summary - Update test counts (381 tests, 78% coverage) - Mark project as FEATURE COMPLETE - List all 14 implemented commands Phase 7 deliverables: - Config commands (get/set/list/reset/edit) ✅ - Doctor command with system diagnostics ✅ - Shell completion (bash/zsh/fish) ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.