Merged
Conversation
Fix profile directory creation to use proper permissions (0o755) instead of inheriting restrictive umask, preventing Chrome/Chromium from creating SingletonLock files and causing launch failures. - Use ensure_dir() utility with explicit mode=0o755 for profile directories - Add test to verify correct permissions are set - Document troubleshooting steps for existing affected PWAs Execution Report: - [x] Linting: ruff check src tests (fixed import organization issues) - [x] Type checking: mypy src - [x] Unit tests: pytest -q tests/unit tests/integration tests/e2e (2 unrelated failures in doctor tests) - [x] Coverage: pytest --cov=pwa_forge --cov-report=term-missing -m "not playwright" (playwright not installed, skipped)
Remove Firefox from supported browsers for PWA creation due to lack of native app/SSB mode support. Firefox cannot create true PWAs as it lacks the --app flag and isolated window functionality that Chromium-based browsers provide. **Breaking Change**: Firefox is no longer a valid option for --browser flag in `pwa-forge add` command. - Remove firefox from CLI browser choices (Chrome/Chromium/Edge only) - Add validation to reject Firefox with helpful error message - Update doctor command to distinguish PWA-compatible vs handler-only browsers - Update documentation (README, TROUBLESHOOTING) to clarify browser requirements - Update tests to use Chromium-based browsers only - Add test to verify Firefox rejection Note: Firefox is still supported for URL handlers (generate-handler) to open external links from PWAs. Execution Report: - [x] Linting: ruff check --fix src tests - [x] Type checking: mypy src - [x] Integration tests: pytest tests/integration tests/e2e (99 passed) - [x] New test added: test_add_error_handling_firefox_not_supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.