Fix Mixtral-related issues #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek0chumak
changed the title
mryab
reviewed
Apr 10, 2024
Co-authored-by: Max Ryabinin <mryabinin0@gmail.com>
mryab
reviewed
Apr 10, 2024
tests/test_full_model.py
Outdated
| @@ -141,6 +141,10 @@ def test_sampling(tokenizer, model, ref_model, max_new_tokens=10): | |||
| ), f"Sampling is not identical to HF with {options=}, {multiple_calls=}, {inputs.shape=}" | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif( | |||
| MODEL_NAME.lower().find("bloom") == -1, | |||
| reason="Mixtral and Llama uses DynamicCache, which can change based on beam search choices", | |||
There was a problem hiding this comment.
Suggested change
| reason="Mixtral and Llama uses DynamicCache, which can change based on beam search choices", | |
| reason="Mixtral and Llama use DynamicCache, which can change based on beam search choices", |
tests/test_full_model.py
Outdated
| @@ -141,6 +141,10 @@ def test_sampling(tokenizer, model, ref_model, max_new_tokens=10): | |||
| ), f"Sampling is not identical to HF with {options=}, {multiple_calls=}, {inputs.shape=}" | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif( | |||
| MODEL_NAME.lower().find("bloom") == -1, | |||
There was a problem hiding this comment.
Suggested change
| MODEL_NAME.lower().find("bloom") == -1, | |
| "bloom" not in MODEL_NAME.lower(), |
mryab
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems related to #569:
BS is removed for Mixtral and Llama for now. Those models use DynamicCache, which requires special function to change: (see https://github.com/huggingface/transformers/blob/main/src/transformers/cache_utils.py#L161)