Color and layout #16
Open
Color and layout #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barcode not centered bigship#1 foregroundColor doesn't work bigship#3 Barcode is rendered outside the canvas bigship#13 Code93 barcode has extra bars on the end bigship#14
v0l
reviewed
Oct 10, 2019
Contributor
v0l
left a comment
v0l
left a comment
There was a problem hiding this comment.
LGTM, mostly linting changes
|
This should be merged! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains fixes for the following issues...
Barcode not centered #1
foregroundColor doesn't work #3
Barcode is rendered outside the canvas #13
Code93 barcode has extra bars on the end #14
This is a breaking change, due to the backgroundColor and foregroundColor support added, so the version is updated to 2.0.0 in pubspec.yaml
I also