Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indicator styles flash #1227

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

michaelperel
Copy link
Contributor

In a SPA I am writing, I noticed that when adding an element with an indicator to the DOM, the indicator will "flash" (display for a brief moment). Specifically, in my case this is when content for a page is loaded via the "HX-Location" header.

I am not a CSS expert, but it appears as though the CSS transition is on the wrong element. Instead, the transition should be placed on the elements with opacity: 1 (when the request class is added).

I made that change locally in my app, and the "flashing" behavior went away. Here is a PR for that change.

@alexpetros
Copy link
Collaborator

I am also no CSS expert, but this looks correct to me.

@alexpetros alexpetros added ready for review Issues that are ready to be considered for merging bug Something isn't working labels Nov 5, 2023
@1cg 1cg merged commit 6866175 into bigskysoftware:dev Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants