Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disable-element extension to disable multiple elements #1650

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Allow disable-element extension to disable multiple elements #1650

merged 3 commits into from
Sep 14, 2023

Conversation

imaperson1060
Copy link
Contributor

Allow multiple elements to be selected in the query

Better version of #1639 - this time I actually read the contribution guide

@imaperson1060
Update disable-element extension
05bce4a 
Allow multiple elements to be selected in the query
@imaperson1060 imaperson1060 mentioned this pull request Jul 30, 2023
Closed
@imaperson1060
Copy link
Contributor Author

For some reason, when I run npm test, the hx-boost attribute fails. It's not like this in the browser and I didn't change anything related to hx-boost.

image
image

@alexpetros alexpetros changed the title Update disable-element extension Allow disable-element extension to disable multiple elements Jul 31, 2023
@alexpetros alexpetros added the enhancement New feature or request label Jul 31, 2023
alexpetros
alexpetros reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR; strict, intuitive enhancement and I can't think of any reason why this would cause a regression.

test/ext/disable-element.js Outdated Show resolved Hide resolved
@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Jul 31, 2023
1cg
1cg requested changes Aug 1, 2023
View reviewed changes
src/ext/disable-element.js Outdated Show resolved Hide resolved
@1cg 1cg removed the ready for review Issues that are ready to be considered for merging label Aug 1, 2023
@alexpetros alexpetros mentioned this pull request Aug 27, 2023
Merged
@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Aug 27, 2023
@Telroshan Telroshan mentioned this pull request Aug 27, 2023
Closed
@GPla GPla mentioned this pull request Sep 10, 2023
Open
@1cg 1cg merged commit 6e93780 into bigskysoftware:dev Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpetros alexpetros alexpetros left review comments

@1cg 1cg 1cg requested changes

Assignees
No one assigned
Labels
enhancement New feature or request ready for review Issues that are ready to be considered for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imaperson1060 @1cg @alexpetros