Fix WS sendImmediately #1949
Fix WS sendImmediately #1949
Conversation
|
Looks good, can you explain in more detail on the description what's bugged about the current behavior? |
Issue #1930 : when no sending element is provided to |
| @@ -749,6 +749,24 @@ describe("web-sockets extension", function () { | |||
| window.document.removeEventListener("htmx:wsOpen", handler) | |||
| } | |||
| }) | |||
| it('sends message if no sending element is provided', function (done) { | |||
There was a problem hiding this comment.
@alexpetros This test is the one which would currently fail; no sending element would result in the message being gobbled up.
|
Added your comment to the description, hope that's alright. Just making it easier for 1cg to review. |
alexpetros
added
bug
|
@Renerick can you review, looks like a great change but I want you to see it as well before I merge. |
Description
Fixes #1930.
When no sending element is provided to sendImmediately, the message is not sent to the socket, which contradicts the documentation which states that sendingElt is optional.
This PR:
beforeSendandafterSendon the correct element if providedTo the reviewers, I've noticed that no second level "describe" is used to group the tests. In order to better focus on my own tests, it was easier for me to have a sub section of tests under ws extension. I've left it as is but please let me know if that's an issue.