Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing ignoreTitle property declaration in htmx.config #1981

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Telroshan
Copy link
Collaborator

This option was introduced by c230931 which also added documentation for it, but it seems it was forgotten from the htmx.config object iself
That documentation itself states the following:

defaults to false, if set to true htmx will not update the title of the document when a title tag is found in new content

So I simply added that default value of false in the config

@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Nov 8, 2023
@xhaggi
Copy link
Contributor

xhaggi commented Nov 9, 2023

This option is also missing from the type defs. Would you mind adding it there too?

@Telroshan
Copy link
Collaborator Author

Thx I had forgotten about this file @xhaggi, I'll add it asap

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Nov 10, 2023
@alexpetros alexpetros removed the documentation Improvements or additions to documentation label Nov 16, 2023
@1cg 1cg merged commit d7735ad into bigskysoftware:dev Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants