Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option scrollIntoViewOnBoost to typescript defs #1986

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add config option scrollIntoViewOnBoost to typescript defs #1986

merged 1 commit into from
Nov 16, 2023

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Nov 9, 2023

A follow-up to #1459

@alexpetros
Copy link
Collaborator

alexpetros commented Nov 9, 2023 •
edited
Loading

Please rebase to dev, per the contribution guidelines

@xhaggi xhaggi changed the base branch from master to dev November 9, 2023 21:20
@xhaggi
Copy link
Contributor Author

xhaggi commented Nov 9, 2023

It's based on dev but forgot to adjust the target branch when I created the PR.

@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Nov 9, 2023
koko1928
koko1928 reviewed Nov 10, 2023
View reviewed changes
Copy link

@koko1928 koko1928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. I think this change makes sense and is appropriate because it is consistent.

@1cg 1cg merged commit 748dd0c into bigskysoftware:dev Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koko1928 koko1928 koko1928 left review comments

Assignees
No one assigned
Labels
ready for review Issues that are ready to be considered for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhaggi @alexpetros @koko1928 @1cg