Add missing } in core ajax tests #1990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`keyup` only works with a keyboard, and ignores pasting with a right click or programmatically updating the value with JS. `input` is a better event for detecting any "inputs to the input". Co-authored-by: Sam Eaton <sam@eaton.party>
* docs: php (symfony sdk) * docs: twig support for fragments --------- Co-authored-by: Cristian Toma <cristian.toma@vivre.eu>
* Homogenize configuration docs * Remove source change
Could not figure out how to import directly from docs.md with zola.
rbri
added a commit
to HtmlUnit/htmlunit
that referenced
this pull request
Nov 11, 2023
|
Looks like this bug reduces the number of test in the test suite. After fixing the 1.9.7 release test suite changed from 584 to 653 tests. |
|
Huh, odd, thanks. Can you rebase against |
|
@alexpetros rebased to test - is it ok now? or do you like to have a pr against the dev branch? |
|
Yes, the PR should be against the |
|
So i have to create a new one... |
|
Nope, you can retarget this PR, just rebase it against dev and then edit the PR! |
|
like this? |
|
Yup, but now you have to rebase it against dev so it's only the one commit |
|
Sorry but i will create a new PR. |
|
replaced by #1998 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on improving the js support of HtmlUnit.