Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect config types #2046

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix incorrect config types #2046

merged 1 commit into from
Nov 27, 2023

Conversation

jonathonadams
Copy link
Contributor

Description

This fixes the incorrect type definitions for wsBinaryType introduced in #2026.

It also improves the strictness of the methodsThatUseUrlParams option to be a list of only valid HTTP Methods (as lowercase).

Corresponding issue:
#2026.

Testing

N/A

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@alexpetros alexpetros merged commit b796c8a into bigskysoftware:dev Nov 27, 2023
1 check passed
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Merged
@Jekyle9444 Jekyle9444 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpetros alexpetros alexpetros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathonadams @alexpetros