fix conflicting function names in sse.js #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a function naming conflict after #2025. I missed it because it worked on current dev since htmx.js initialized createEventSource parameter, but after removing it for 2.0, it led to infinite recursion and errors
Corresponding issue: discovered when updating #2095 to latest dev
Testing
I applied the patch to WS/SSE removal branch and ensured that recursion error was gone
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded