Support encapsulating oob swap elements in templates in response #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cg
requested changes
Dec 21, 2023
Telroshan
force-pushed
the
oob-swap-templates
branch
from
7d07d83 to
3889b8a
Compare
Renerick
added a commit
to Renerick/Htmx.Oob
that referenced
this pull request
Jan 18, 2024
Support for this behavior was added in bigskysoftware/htmx#2120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Discord, here's a template-based suggestion to work around the annoying scenario of oob-swapping the lone
trortdto, which by default won't work if there are any elements before it in the response, because of the way the DOM parser works.Updated the docs to mention that scenario and the way we would now recommend to address it.