Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect external script info from client-side-templates docs #2184

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

kgscialdone
Copy link
Contributor

I don't know why this was in here in the first place, it's just outright false. Neither Mustache nor the CST extension have any sort of code to enable using <script type="text/mustache"> like this. The <object>-based example for XSLT templates should probably be double-checked too.

Description

Removed erroneous text from https://htmx.org/extensions/client-side-templates/

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

I don't know why this was in here in the first place, it's just outright false. Neither Mustache nor the CST extension have any sort of code to enable using `<script type="text/mustache">` like this. The `<object>`-based example for XSLT templates should probably be double-checked too.
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, thanks.

@alexpetros alexpetros merged commit 807197e into bigskysoftware:master Jan 12, 2024
1 check passed
@ASoldo
Copy link

ASoldo commented Jan 12, 2024

Thank you!

lsymds pushed a commit to lsymds/htmx that referenced this pull request Jan 20, 2024
…bigskysoftware#2184)

I don't know why this was in here in the first place, it's just outright false. Neither Mustache nor the CST extension have any sort of code to enable using `<script type="text/mustache">` like this. The `<object>`-based example for XSLT templates should probably be double-checked too.
rekado pushed a commit to rekado/htmx that referenced this pull request Feb 9, 2024
…bigskysoftware#2184)

I don't know why this was in here in the first place, it's just outright false. Neither Mustache nor the CST extension have any sort of code to enable using `<script type="text/mustache">` like this. The `<object>`-based example for XSLT templates should probably be double-checked too.
FraserChapman pushed a commit to FraserChapman/htmx that referenced this pull request Feb 16, 2024
…bigskysoftware#2184)

I don't know why this was in here in the first place, it's just outright false. Neither Mustache nor the CST extension have any sort of code to enable using `<script type="text/mustache">` like this. The `<object>`-based example for XSLT templates should probably be double-checked too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants