Clarify hx-validate documentation #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekado
pushed a commit
to rekado/htmx
that referenced
this pull request
Feb 9, 2024
FraserChapman
pushed a commit
to FraserChapman/htmx
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2185
Description
The hx-validate documentation says "Form elements do this by default, but other elements do not" which is quite confusing, I interpreted this to also mean
<input>elements validate by default. This PR solves that confusion and also makes it clear that hx-validate must be set to "true".This change has not been explicitly approved by the maintainers via the issue, hope that's ok. If not, please let me know and I won't make a PR next time until it's approved.
Corresponding issue: #2185
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded