fix sse-swap removal handling in ext/sse.js #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renerick
added
bug
Telroshan
approved these changes
Feb 25, 2024
Renerick
added a commit
to bigskysoftware/htmx-extensions
that referenced
this pull request
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sse.js was not returning from handler after removing event listeners when sse-swap element was replaced/removed from the DOM. This lead to errors when removed element was target for swapping
Corresponding issue: https://discord.com/channels/725789699527933952/1200403330254520320
Testing
I added new test case to test/ext/sse.js and also ran manual tests with the test server
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded