Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit-row example #2273

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix edit-row example #2273

merged 1 commit into from
Feb 5, 2024

Conversation

sake92
Copy link
Contributor

@sake92 sake92 commented Feb 2, 2024

Description

This PR fixes the logic in the edit-row example.

Corresponding issue: #2223

Testing

I have tested it locally.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

alexpetros
alexpetros approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you!

@alexpetros alexpetros merged commit 3d0ec85 into bigskysoftware:master Feb 5, 2024
@sake92 sake92 deleted the fix-2223-edit-row-example branch February 5, 2024 21:34
rekado pushed a commit to rekado/htmx that referenced this pull request Feb 9, 2024
@sake92 @rekado
Fix edit-row example (bigskysoftware#2273)
f09a891
FraserChapman pushed a commit to FraserChapman/htmx that referenced this pull request Feb 16, 2024
@sake92 @FraserChapman
Fix edit-row example (bigskysoftware#2273)
660b306
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Merged
@Jekyle9444 Jekyle9444 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpetros alexpetros alexpetros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sake92 @alexpetros