Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show element used for hx-indicator in value-select example code #2275

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Show element used for hx-indicator in value-select example code #2275

merged 1 commit into from
Feb 5, 2024

Conversation

mheptinstall
Copy link
Contributor

@mheptinstall mheptinstall commented Feb 3, 2024 •
edited
Loading

Description

Code examples does not include element with class .htmx-indicator used for hx-indicator attribute

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@mheptinstall
Show element used for hx-indicator in example code
93dbba6 
Code examples does not include element with class `.htmx-indicator` used for hx-indicator attribute
alexpetros
alexpetros approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@alexpetros alexpetros merged commit f18cbc5 into bigskysoftware:master Feb 5, 2024
rekado pushed a commit to rekado/htmx that referenced this pull request Feb 9, 2024
@mheptinstall @rekado
Show element used for hx-indicator in value-select example code (bigs…
632a737 
…kysoftware#2275)

Show element used for hx-indicator in example code

Code examples does not include element with class `.htmx-indicator` used for hx-indicator attribute
FraserChapman pushed a commit to FraserChapman/htmx that referenced this pull request Feb 16, 2024
@mheptinstall @FraserChapman
Show element used for hx-indicator in value-select example code (bigs…
19cb97a 
…kysoftware#2275)

Show element used for hx-indicator in example code

Code examples does not include element with class `.htmx-indicator` used for hx-indicator attribute
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 3, 2024
Merged
@Jekyle9444 Jekyle9444 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpetros alexpetros alexpetros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mheptinstall @alexpetros