Fixes issue 1537 - OOB does not escape query selector

[FraserChapman]

Description

This change alters how the oobSwap function builds the query selector string. Rather than simply prefixing it with a # it uses the '[id="raw_id"]' format. Where raw_id is the value obtained from getRawAttribute(oobElement, "id")

Ideally this could be done more cleanly with template literals (backtick strings) - but as I understand it you want to support IE11.

This fix allows the call querySelectorAll to return the nodelist of all elements with the ids such as "foo-/bar" - without getting "Failed to execute 'querySelectorAll' on 'Document': '#foo-/bar' is not a valid selector, and whilst not limiting the selection to the first matching id in the document.

Corresponding issue:

#1537

Testing

I ran the htmx.js test suite Version: 1.9.10 and got 0 failures
I also manually tested ids such as "foo-/bar" and it all seems to be working as expected.

Further to this I've added test cases for

'handles elements with IDs containing special characters properly'

and

'handles one swap into multiple elements with the same ID properly'

And re- ran the htmx.js test suite Version: 1.9.10 and got 0 failures

Checklist

• I have read the contribution guidelines
• I have targeted this PR against the correct branch (master for website changes, dev for
  source changes)
• This is either a bugfix, a documentation update, or a new feature that has been explicitly
  approved via an issue
• I ran the test suite locally (npm run test) and verified that it succeeded

[MAW016]

Wouldn't be nicer to use CSS.escape()?

let selector = '#' + CSS.escape(getRawAttribute(oobElement, 'id'))

[FraserChapman]

Yes it would be nicer...but as I understood it htmx v1 maintains support for Internet Explorer 11 and CSS.escape isn't supported.

[MAW016]

hmm I am curious how this fix will be propagated to v2... Contribution rules says PR only into dev.

[FraserChapman]

Contribution rules says PR only into dev.

I'm not sure what you mean, this is a PR into bigskysoftware/htmx:dev

[Telroshan]

Hey @FraserChapman , following up late on this (sorry about that!)
If you are still interested in this change, could you resolve conflicts?

as I understood it htmx v1 maintains support for Internet Explorer 11 and CSS.escape isn't supported.

Since then, we released htmx 2 which dropped IE11 support, so feel free to use that method if you want 😄