Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some IE11 incompatibilities
function makeTagRegEx(tag, global = false)
, not supported by IE11htmx.processNode
on text nodes (i.e. not actualElement
s). This fails gracefully on modern browsers but not so gracefully on IE11. Added 2 checks in hx-on processing functions, to avoid calling undefined references (a text node doesn't have.attributes
neithergetElementsByTagName
)Corresponding issue:
Testing
See #1687 with the procedure to run tests on IE11
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded