Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fire htmx:trigger event on delayed triggers #2411

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

WKBae
Copy link
Contributor

@WKBae WKBae commented Mar 18, 2024

Description

hx-trigger with delay modifier did not fire htmx:trigger event. This behavior was inconsistent with plain(non-delay) events.
Demo: https://jsfiddle.net/yu59noed/

Testing

Added test case for delayed htmx:trigger. This test case failed on current dev branch.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Mar 18, 2024
@zoladkow
Copy link

zoladkow commented Apr 8, 2024

Hi @WKBae I just found the same inconsistency and found your fix for that is already in the pipeline! Good work! However it seems your fix could also cover the throttle modifier as looking at the code, few lines above your fix, it seems it suffers from same omission.

Thanks in any case! :)

@1cg
Copy link
Contributor

1cg commented May 15, 2024

good fix, please retarget to dev

@WKBae WKBae changed the base branch from master to dev May 16, 2024 13:47
@WKBae
Copy link
Contributor Author

WKBae commented May 16, 2024

@1cg Oh I forgot to change it. Thanks for the reminder!

@Telroshan Telroshan added ready for review Issues that are ready to be considered for merging and removed ready for review Issues that are ready to be considered for merging labels Jul 22, 2024
@Telroshan
Copy link
Collaborator

Hey @WKBae , are you still interested in that change ? If so, please rebase to dev and resolve conflicts, thanks!

@WKBae WKBae force-pushed the htmx-trigger-on-delay branch from 6d459a7 to 65d549c Compare July 26, 2024 08:54
@WKBae
Copy link
Contributor Author

WKBae commented Jul 26, 2024

Hi @Telroshan, I've rebased the branch to current dev.

@Telroshan Telroshan added ready for review Issues that are ready to be considered for merging and removed needs rebase/retarget labels Jul 26, 2024
@1cg 1cg merged commit 2741255 into bigskysoftware:dev Aug 5, 2024
1 check passed
@1cg
Copy link
Contributor

1cg commented Aug 5, 2024

I have merged this change and @zoladkow i added the event for throttled events as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants