Ws fix hx vals number handling #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aral
added a commit
to aral/htmx
that referenced
this pull request
Mar 19, 2024
4 tasks
Renerick
force-pushed
the
ws-fix-hx-vals-number-handling
branch
from
43b37d4 to
60a0beb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #2417. It changes getExpressionVar to return JS object instead of FormData, converting it to FormData only when it's needed (in XHR request serialization) and utilizing it in ws js by using mergeObjects again
Corresponding issue:
Testing
ws-sse test server, the tests are green. Draft as this solution has not been discussed yet