Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example buttons in darkmode #2719

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

Rooyca
Copy link
Contributor

@Rooyca Rooyca commented Jul 12, 2024

Description

Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.

Corresponding issue:

Testing

Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the website Non-documentation website issues label Jul 13, 2024
@Telroshan
Copy link
Collaborator

Fortunately it's only 2 additional classes so I could easily try this out in the browser's dev tools directly, but please include screenshots of before/after your changes for PRs like this one, so we can directly see the changes in this very issue!

For reference:

  • Before:
    image
  • After:
    image

@Telroshan Telroshan merged commit 1136d26 into bigskysoftware:master Jul 13, 2024
1 check passed
cngJo pushed a commit to jop-software/htmx that referenced this pull request Jul 13, 2024
pfiadDi pushed a commit to pfiadDi/htmx that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Non-documentation website issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants