Fix package.json configuration for types #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you push a version of this without the changes to |
|
Actually, I think I just targeted the wrong branch, sorry about that. Should be cleaner now. |
|
Awesome, thank you! |
alexpetros
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing deployment settings for types.
Corresponding issue:
Following up on the following comment: #2734 (comment)
Testing
When using the "local install" strategy with
npm, it seems that thefilesparameter is ignored, so I don’t have any good way of testing this. It looks cleaner to get that changed though. I also did a full search forhtmx.d.tsand don’t find anything left now.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded