Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to resize events and check revealed #2780

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Listen to resize events and check revealed #2780

merged 1 commit into from
Aug 29, 2024

Conversation

kulik0v
Copy link
Contributor

@kulik0v kulik0v commented Aug 1, 2024

Description

It is possible that element can be revealed not only because of scroll but because window size is changed or other elements in a page dynamically changed.

Corresponding issue:

Testing

  1. Load test page in small window with test element (activated by hx-trigger="revealed") below visible area.
  2. Resize the window.
  3. When test element is visible revealed event is missing.

Checklist

  • [yep] I have read the contribution guidelines
  • [dev] I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • [fix] This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Aug 1, 2024
@alexpetros
Copy link
Collaborator

This looks good

@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Aug 21, 2024
@1cg 1cg merged commit 324ee19 into bigskysoftware:dev Aug 29, 2024
1 check passed
@1cg
Copy link
Contributor

1cg commented Aug 29, 2024

great fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants