Better graceful degradation of boosted form element #2802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The expected behaviour of a form is not currently adhered to in htmx, making hx-boost degrade in an unexpected way for forms. (I have only tested this on chrome, safari and firefox)
When the action attribute is not set on a form with hx-boost and there are query params in the url, these values are included in the request as well as any values from the form. This does not match how forms normally handle an empty action attribute without hx-boost.
Another attempt at #1811
Corresponding issue: #1788
Testing
I have tested this manually in one of my own projects.
I'm happy to implement anything in the htmx test suite but unsure how to mock query params in url in the tests I looked into.
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded -652 passing (5s), 3 pending