[FIX] Properly remove request indicators #2860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug:
When
htmx-request
is placed on the same element that is disabled byhx-disabled-elt
request count is increased twice on the same element. However, when removing request indicators, the request counts for indicators and disabled elements are deducted separately. This meant that when checking the indicators, request count would not be 0, andhtmx-reqest
is not properly removed.Solution:
Deduct request counts first for both indicators and disabled elements, before removing request indicators.
Corresponding issue: #2295 #2234
Also in extensions repo: bigskysoftware/htmx-extensions#79
Testing
Tested with a personal project as well as using the sample code provided in the issues.
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded