Change hx-trigger's changed modifier to work for independent trigger specifications #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `changed` trigger modifier can see different event targets, either due to the `from` modifier or event bubbling. The existing behavior trigger only for one node (`from` modifier) or inconsistently (bubbling). Use a nested weak map to keep track of the last value per distinguished (trigger specification, event target node) pair. The weak map ensures that Garbage Collection can still recycle the nodes. If a event target was not seen via `from`, it is assumed changed for the first time the trigger is hit.
4 tasks
Telroshan
approved these changes
Sep 11, 2024
Telroshan
added
bug
This was referenced Sep 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trigger specifications can reference multiple HTML nodes via from and a single element can have multiple trigger specifications for different HTML nodes. One example is given in #2056. Active search with multiple search fields is another one. The latter doesn't currently work because the trigger needs to be on the form element, but the logic doesn't check the event target, but only the element itself.
Corresponding issue: #2056
Testing
Test case covers the original problem from #2056 as well as the related case of referencing different elements. Both tests fail without the implementation change.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded