Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation for htmx:confirm event and examples for implementing sweetalert #2926

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

eduardolat
Copy link
Contributor

Description

This PR is an update of the #2868 PR, sorry for the delay but I was very busy with my work.

I've read @Telroshan comments and have clarified it further so that everyone understands how it works.

I've also modified the file www/content/examples/confirm.md since the example didn't work correctly and I've added some comments clarifying how it works.

I hope this time everything is much clearer, I look forward to your comments, thank you very much!

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@alexpetros
Copy link
Collaborator

@Telroshan this looks reasonable to me, let me know what you think

Copy link
Collaborator

@Telroshan Telroshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good inline comments to clarify, and it's cool that you added a basic example to instruct the general process!
Just allow me one question and I'll stop bothering you 😆

www/content/events.md Outdated Show resolved Hide resolved
@Telroshan Telroshan added the documentation Improvements or additions to documentation label Sep 23, 2024
@Telroshan Telroshan merged commit 27b5bcc into bigskysoftware:master Sep 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants