Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError on null path variable #2967

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

youssame
Copy link
Contributor

Description

I check if the path is null or empty when the user hasn't set the action property or has left it empty.

Corresponding issue: #2963

Testing

I added two tests that check if everything is OK in two cases (action is unset or is empty)

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Oct 15, 2024
@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Oct 15, 2024
@1cg 1cg merged commit 3e265ea into bigskysoftware:dev Oct 20, 2024
1 check passed
@1cg
Copy link
Contributor

1cg commented Oct 20, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants