fix vertical alignment of github stars button in all states #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without uBlock, the button's alt-text would be 1px lower than the rest of the nav items, and inconsistently capitalized. With uBlock, the button would be slightly too high up. This is on Firefox. The solution is to apply styles on the `span` that GitHub's JS inserts. However, using margin will make the entire nav jump during pageload, so position: relative seems more robust there.
Telroshan
added
website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without uBlock, the button's alt-text would be 1px lower than the rest
of the nav items, and inconsistently capitalized.
With uBlock, the button would be slightly too high up. Screenshot of problem:
The solution is to apply styles on the
spanthat GitHub's JS inserts.However, using margin will make the entire nav jump during pageload, so
position: relative seems more robust there.
Testing
Tested in Firefox and Chrome latest
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded