Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babystep reset fix #2654

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

kisslorand
Copy link
Contributor

@kisslorand kisslorand commented Dec 22, 2022

Requirements

BTT or MKS TFT

Description

If BABYSTEP_DEFAULT_VALUE in "Configuration.h" is defined other than 0 (zero) than "Babystep reset" doesn't function as expected:

  • if the babystep value is equal to BABYSTEP_DEFAULT_VALUE than babystep value remains unchanged otherwise it always resets to 0 (zero) and not to the defined babystep default value
  • Z offset value will not reset to it's original value, it will have unexpected values, depending on the previous babystep value

Steps to reproduce:

  • set BABYSTEP_DEFAULT_VALUE to any other value than 0 (zero) in the source code, compile and upload it to your TFT
  • go to Settings -> Move -> Babystep menu
  • press "Reset" repeatedly a few times and observe Z offset value
  • change babystep value, press "Reset" and observe the new resulting babystep and Z offset value

This PR is meant to fix these and make "Reset babystep" to behave as expected.

Benefits

  • using BABYSTEP_DEFAULT_VALUE other than 0 (zero) will not mess up the "Babystep reset" procedure

Related Issues

  • none reported

@kisslorand kisslorand force-pushed the Babystep-reset-bugfix branch 2 times, most recently from b38fad3 to e998cd5 Compare January 23, 2023 22:16
@kisslorand kisslorand force-pushed the Babystep-reset-bugfix branch 3 times, most recently from 90be24b to c6652c8 Compare February 15, 2023 12:07
@bigtreetech bigtreetech merged commit 0e80ebc into bigtreetech:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants