-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better support for Printer SD / TFT SD /TFT USB from ESP3D and other extern prog #648
Conversation
Hi! This sounds good. Could it be possible to support ESP32-CAM as well? Maybe we can solve it so that we can monitor the printer remotely with the camera? |
what the tft must do to support esp32 cam? |
I do not know. I just asked how this could be solved. |
@AntoszHUN you do not know what kind of support you ask for ? I am sorry I do not understand
But what need to be solved ? You must have an idea of what you expect if you ask for it it is confusing - I suggest you to post a Feature request explaining what you expect/wish Note: ESP3D already support ESP32 Cam - but there is not relationship with TFT code and this PR |
Sorry! Maybe the translator didn't translate well what I wrote. I started a request but no one has responded to it yet. I started several days ago. #597 There is no answer. Am I just interested in seeing the print from a distance? Could it be programmed into the TFT program? |
This #597 is not related to this PR at all but bring confusion you can connect an ESP32-cam or any ESP board to the TFT - you just need to do proper wiring - no need any update in TFT code as the camera do not need to communicate with the TFT |
I understand. So can I still see the camera image from a distance? |
Add M300 TFT support to use buzzer
@luc-github will it be feasible to use a G-code prefix other than |
well I have used standard GCODE why introduce new ones ? they are documented and function is identical to original usage
I feel more confusing to use different gcode for same purpose and in all case need to put the target source of the file SD: and U: to let tft know which is the target @guruathwal please explain more your proposal as I do not see the point sorry |
@luc-github I am not discussing this PR. I was talking about overall functionality. like switching to a specific menu on TFT from ESP, Starting or stopping a function on the TFT like the M105 / M114 polling loops or disconnecting & connecting the serial to the printer etc. |
@guruathwal ok I understand better, thank you for clarifying I think any function can be added, it is just a matter of specs ^_^ the key point is the command need to be catched and not forwarded to printer
I personnaly think the third one should be used when GCODE exists for consistency to avoid to create new code when function exists for printer I won't recommand the 2 last as wrote but they are also possible The limit is your imagination 😸 |
@luc-github I think the first one is well suited for this purpose. |
I want to know if it will be possible in the future to send files to TFT SD directly from CURA, approximately like in octoprint or MKS WiFi? |
I will be happy, if the possibility to upload a file to the tft SD or USB will be available soon. |
…her extern prog (bigtreetech#648) * Broadcast temperatures to Serial 2 * Allow to list TFT SD and TFT USB using GCODE * Allow Upload to Printer SD by disabling TFT polling during upload * Revert to original github address in M115 * Fix bad copy/past paste in M115 Add M300 TFT support to use buzzer
This would be pure awesomeness! |
@kisslorand luc-github/ESP3D#575 need to be done first to implement serial upload |
Description
Add better support for listing files / start print / delete file of TFT SD and TFT USB, uploading file to printer SD and TFT capabilities
Benefits
More features allowing listing files / start print / delete file of TFT SD and TFT USB
by adding a hook when SD: or U: is added in front of file path
e.g.:
M20 SD:
List TFT SD filesM20 U::
List TFT USB filesthis apply to:
Additional features
M28 / M29 now disable/enable TFT polling and so allow to upload files to printer SD card using this protocol
M300 TFT to send M300 gcode to TFT only if printer does not support it
Note: I did not added the upload to TFT SD neither TFT USB but it can be added later
Related Issues
#261