Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Somatic template #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Somatic template #34

wants to merge 3 commits into from

Conversation

sellth
Copy link
Collaborator

@sellth sellth commented Oct 26, 2023 •
edited
Loading

  • catalogue IDs should be comments (secondary information on parameter)
  • remove ontology columns from units (cleaner)
  • add ontology reference for Measurement Types

@sellth sellth requested review from ericblanc20 and mbenary July 3, 2024 15:12
@sellth sellth marked this pull request as ready for review July 3, 2024 15:12
ericblanc20
ericblanc20 reviewed Jul 3, 2024
View reviewed changes
Copy link

@ericblanc20 ericblanc20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good. I'll approve it, just want to give you a chance to comment on the units.

...cookiecutter.__output_dir}}/a_{{cookiecutter.s_file_name}}_{{cookiecutter.__assay_name}}.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you don't want to use the UO units of measurement ontology?

...tic/{{cookiecutter.__output_dir}}/a_{{cookiecutter.s_file_name}}_transcriptome_profiling.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you don't want to use the UO units of measurement ontology?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I don't think it is necessary to define these Units using UO, it is not supported by SODAR anyway, and therefore I removed this complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericblanc20 ericblanc20 ericblanc20 left review comments

@mbenary mbenary Awaiting requested review from mbenary

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sellth @ericblanc20