-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: 237 revive cnvkit #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicolai-vKuegelgen
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything glaring, so overall lgtm.
However, keep in mind that I'm not overly familiar with these tools, and I didn't specifically check that the snappy/snakemake changes all work out.
…arget in output, fixed typos
ericblanc20
force-pushed
the
237-revive-cnvkit
branch
from
January 17, 2023 11:17
38cf8a7
to
f7c14f9
Compare
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panel_of_normals
step to create acnvkit
reference based on exome of wgs normal samplescnvkit
tool for thesomatic_targeted_seq_cnv_calling
.cnvkit
as tool for thesomatic_wgs_cnv_calling
stepNote that the changes break the plots creation for the
control_freec
tool in thesomatic_wgs_cnv_calling
step. Following a discussion with Manuel, this step will need to be refurbished anyway, and possibly merged with thesomatic_targeted_seq_cnv_calling
step, which performs the same function for exome data.