Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: 237 revive cnvkit #339

Merged
merged 10 commits into from
Jan 23, 2023
Merged

feat!: 237 revive cnvkit #339

merged 10 commits into from
Jan 23, 2023

Conversation

ericblanc20
Copy link
Contributor

  • Extends the panel_of_normals step to create a cnvkit reference based on exome of wgs normal samples
  • Updates & extends the cnvkit tool for the somatic_targeted_seq_cnv_calling.
  • Allows cnvkit as tool for the somatic_wgs_cnv_calling step

Note that the changes break the plots creation for the control_freec tool in the somatic_wgs_cnv_calling step. Following a discussion with Manuel, this step will need to be refurbished anyway, and possibly merged with the somatic_targeted_seq_cnv_calling step, which performs the same function for exome data.

Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything glaring, so overall lgtm.
However, keep in mind that I'm not overly familiar with these tools, and I didn't specifically check that the snappy/snakemake changes all work out.

@ericblanc20 ericblanc20 changed the title 237 revive cnvkit feat!: 237 revive cnvkit Jan 17, 2023
@coveralls
Copy link

Coverage Status

Coverage: 85.037% (+0.4%) from 84.613% when pulling cae427d on 237-revive-cnvkit into 5ecad1a on main.

@ericblanc20 ericblanc20 merged commit bc4c55b into main Jan 23, 2023
@ericblanc20 ericblanc20 deleted the 237-revive-cnvkit branch January 23, 2023 08:44
@tedil tedil mentioned this pull request Jun 28, 2024
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants