Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: path_exon_bed can be provided independent of data type (#389) #390

Conversation

holtgrewe
Copy link
Member

Previously, the BED file value was always used for WGS data and never used for WES data. Now, it is used when it has been provided (not the empty string and not null/None).

CC @xiamaz

Previously, the BED file value was always used for WGS data and never
used for WES data.  Now, it is used when it has been provided (not
the empty string and not null/None).
@holtgrewe holtgrewe linked an issue Apr 20, 2023 that may be closed by this pull request
@github-actions
Copy link

Coverage Status

Coverage: 84.938% (+0.002%) from 84.935% when pulling c12c26c on 389-change-behaviour-of-varfish_export-with-path_exon_bed into 35cbe09 on main.

@coveralls
Copy link

Coverage Status

Coverage: 84.962% (+0.03%) from 84.935% when pulling c12c26c on 389-change-behaviour-of-varfish_export-with-path_exon_bed into 35cbe09 on main.

Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolai-vKuegelgen Nicolai-vKuegelgen merged commit 7759d4d into main Apr 20, 2023
@Nicolai-vKuegelgen Nicolai-vKuegelgen deleted the 389-change-behaviour-of-varfish_export-with-path_exon_bed branch April 20, 2023 06:56
@tedil tedil mentioned this pull request Jun 28, 2024
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change behaviour of varfish_export with path_exon_bed
3 participants