-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list value support for missing fields #1789
Comments
It's not broken, it has never been implemented. I haven't been told this is a feature in altamISA nowadays. If all characteristics and factor values are to be included, this will be a major change. We will have to see about prioritization. |
Actually, the AltamISA part is wrong. I did not check before, but it seems like AltamISA is not processing these values into lists. So the issue as of now is: adding semicolons using SODAR's own samplesheet editor results in weird code being shown or an uncaught exception during rendering. |
It's not really weird code if the value is unsupported :) The crash should be avoided though. Can you (privately) send me a copy of the samplesheets where such a crash occurs? |
Altamisa feature request: bihealth/altamisa#140 |
Doing this as a part of #2033. |
Done. If I overlooked something or you run into bugs, please open new ticket(s) about it. |
Describe the Bug
Inputting a semicolon separated list in any
Characteristics
,Comment
,Parameter
, orFactor
field results in AltamISA creating a list value for that object. In case of Characteristics and Parameters these lists are handled by SODAR without any problems. Lists in special protocol parameterPerformer
fields however result in raw Python list notation being rendered (i.e.['Person 1', 'Person 2']
). Entering semicolons inComment
fields results in an exception and a no longer usable ISA-tab.How to Reproduce
Expected Behavior
Lists should be rendered in a similar way to
Characteristics
andParameter
fields. AsComments
andPerformer
fields cannot be differentiated from "normal" characteristics and parameters in the SODAR samplesheet editor, this case needs to be handled. Putting multiple performers for aProcess
is actually a useful option when more than one person should be credited.Screenshots
The text was updated successfully, but these errors were encountered: