Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sheet creation error from slashes in investigation title #1896

Closed
mikkonie opened this issue Feb 7, 2024 · 2 comments
Closed

Sheet creation error from slashes in investigation title #1896

mikkonie opened this issue Feb 7, 2024 · 2 comments
Assignees
@mikkonie
Labels
app: samplesheets Issue in the samplesheets app bug Something isn't working environment Issues of dependencies, CI, deployment etc.
Milestone
v0.14.2

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Feb 7, 2024 •
edited
Loading

When creating sample sheets from template, we get an unexpected error if the investigation title contains slashes:

ISA-Tab import failed: [Errno 2] No such file or directory: '/tmp/tmpuvoltlic/Template_Test/a_investigation_title/slash_Biocrates_MxP_Quant_500_Kit_LC.txt'

We need to replace the characters internally to prevent this. Slashes in titles should still be allowed.
@mikkonie mikkonie added bug Something isn't working tbd Comments wanted, spec/schedule/prioritization to be decided, etc. app: samplesheets Issue in the samplesheets app labels Feb 7, 2024
@mikkonie mikkonie added this to the v0.14.2 milestone Feb 7, 2024
@mikkonie mikkonie self-assigned this Feb 7, 2024
@mikkonie mikkonie added environment Issues of dependencies, CI, deployment etc. and removed tbd Comments wanted, spec/schedule/prioritization to be decided, etc. labels Feb 7, 2024
@mikkonie
Copy link
Contributor Author

mikkonie commented Feb 8, 2024

It turns out this actually happens in cubi-isa-tempates, will open a separate ticket there.

@mikkonie mikkonie mentioned this issue Feb 8, 2024
Closed
mikkonie added a commit that referenced this issue Feb 9, 2024
@mikkonie
fix sheet template creation with slash in id/title field (#1896)
a3100ca
@mikkonie
Copy link
Contributor Author

mikkonie commented Feb 9, 2024

Fixed. Should upgrade to the next cubi-isa-templates release once it's tagged, but a dev commit is fine for now.

@mikkonie mikkonie closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: samplesheets Issue in the samplesheets app bug Something isn't working environment Issues of dependencies, CI, deployment etc.
Projects
None yet
Milestone
v0.14.2
Development

No branches or pull requests
1 participant
@mikkonie