Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement frame-to-frame video navigation #821

Closed
wants to merge 4 commits into from

Conversation

ToukL
Copy link
Contributor

@ToukL ToukL commented May 2, 2024

WARNING: this works only in Chrome (not in Firefox). Not tested in other navigators.

  • Adds a 'Jump step' setting to directly jump a certain amount of seconds backward and forward

Changes video navigation buttons:

  • step-backward and step-forward are used to go to previous and next frames in video
  • add double-backward and double-forward buttons for Jump step setting
  • add chevron-left and chevron-right to go to previous/next video of volume

@mzur
Copy link
Member

mzur commented May 2, 2024

This is an interesting approach! I need to test this thoroughly with different videos because I had so much trouble with this in the past. There are also a couple of things that could be streamlined for the final implementation but I'll get to that once I tested it a bit.

However, this also implements the "jump forward/backward by a fixed number of seconds", right (#262)? Could you please split this from the "jump frame-by-frame" changes and send both in separate PRs? The jumping by seconds can be merged much sooner then.

@mzur mzur mentioned this pull request May 2, 2024
@mzur
Copy link
Member

mzur commented May 2, 2024

For the record: I mentioned the workaround in the W3C discussion I follow and others say that it might not produce perfect results in all cases. This article recommends the WebCodecs API for frame-accurate applications. I had a look at this, too, but as the linked StackOverflow answer mentions, it only works if the media is demuxed. And I think there is no easy solution for that if we still allow many different video file formats in BIIGLE.

@ToukL
Copy link
Contributor Author

ToukL commented May 2, 2024

I did split the PR in two.

I know it's just a workaround that needs more testing and cleaning, if you have time and ideas for that it would be great ! I implemented it like that because we need the frame-by-frame navigation, even if not perfect fro now. I'm open to any suggestion though !

@mzur
Copy link
Member

mzur commented May 3, 2024

Thanks! We'll continue in the new PRs.

@mzur mzur closed this May 3, 2024
@ToukL ToukL deleted the video-navigation branch June 20, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants