Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent double click on submit of a new project #891

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Prevent double click on submit of a new project #891

merged 3 commits into from
Jul 25, 2024

Conversation

dlangenk
Copy link
Member

fixes #335. Uses js events. Is there a better way?

@dlangenk dlangenk requested a review from mzur July 24, 2024 19:59
mzur
mzur reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it like this, which is essentially the same but shorter:

core/resources/views/auth/register.blade.php

Line 115 in b224653

<input type="submit" class="btn btn-success btn-block" value="Sign up" onclick="this.disabled=true;this.form.submit();">

@mzur mzur changed the title create prj: disable button on submit Prevent double click on submit of a new project Jul 25, 2024
@dlangenk dlangenk requested a review from mzur July 25, 2024 07:32
@mzur mzur merged commit d9b3f7e into master Jul 25, 2024
6 checks passed
@mzur mzur deleted the disableSubmitBtnPrj branch July 25, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzur mzur mzur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent double click on submit of a new project
2 participants
@dlangenk @mzur