-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file sort for last created annotations #903
Conversation
Ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement an API endpoint that returns the timestamps for the images instead of passing them on to the view every time. This could be a lot of data if the volume is large and it could be unnecessary data if the sorter is not used. The getSequence()
method of the sorting component already returns a promise so taking the result of an API request here should work out of the box.
Also you should implement getting the timestamps for each file in a single database query (hint: combine groupBy
with max
). Currently you fetch all annotations of the entire volume and this could be literally hundreds of thousands.
This reverts commit 7b586f1.
Add a new file sort to the volume overview, where files are sorted by their latest annotation.
Closes #477.