Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow review of storage requests that were not submitted #35

Closed
mzur opened this issue Jul 4, 2024 · 3 comments · Fixed by #52
Closed

Don't allow review of storage requests that were not submitted #35

mzur opened this issue Jul 4, 2024 · 3 comments · Fixed by #52
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mzur
Copy link
Member

mzur commented Jul 4, 2024

The storage request controller shows only requests that were not approved yet but it does not hide requests that were not submitted. Requests that were not submitted should not be shown by the controller. Fix this and add an appropriate test case.

@mzur mzur added bug Something isn't working good first issue Good for newcomers labels Jul 4, 2024
@mzur mzur moved this to Medium Priority in BIIGLE Roadmap Jul 4, 2024
@mzur
Copy link
Member Author

mzur commented Jul 24, 2024

The tests are here. It also includes an example for a 404 response when the storage request was already reviewed. The same should be expected for a storage request that was not submitted.

@lehecht
Copy link
Contributor

lehecht commented Jan 9, 2025

@mzur
Where are the unsubmitted storage requests displayed?

@mzur
Copy link
Member Author

mzur commented Jan 9, 2025

Admins/reviewers can see the storage requests. Usually they only click on the URL in a helpdesk notification but if they modify the ID in the URL they can see unsubmitted storage requests, too. These could be "approved" even though they are not finished yet. That should not be possible.

@mzur mzur closed this as completed in #52 Jan 10, 2025
@mzur mzur closed this as completed in f3a5325 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
3 participants